Hi. I did: go get "github.com/spiral/goridge" composer require spiral/goridge cd ~/go/src/goridge/vendor/spiral/goridge/examples go run ./

And ran the folowing script:

`<?php use Spiral\Goridge; require "vendor/autoload.php";

$t1 = microtime(true); $rpc = new Goridge\RPC( new Goridge\SocketRelay("127.0.0.1", 6001) ); echo $rpc->call("App.Hi", "Antony"); $t3 = (float)microtime(true) - (float)$t1;

echo ": $t3 | "; $t1 = microtime(true); echo $rpc->call("App.Hi", "Antony"); $t2 = microtime(true); $t3 = (float)$t2 - (float)$t1; echo ": $t3" . PHP_EOL;`

I got a result: Hello, Antony!: 0.00071406364440918 | Hello, Antony!: 0.041256904602051 Is it a bug? Or I made mistake?

** Thank for your job!

Windows 10 now supports basic functionality of AF_UNIX sockets. Consequently, restriction on Unix sockets on Windows was removed in Go and thus can be removed in goridge.

I tried this code:

<?php

use Spiral\Goridge\RPC\RPC;

require __DIR__ . '/vendor/autoload.php';

RPC::create('tcp://127.0.0.1:6001')
  ->call('unknown-method', null);

I expected to see this happen:

Error 'rpc: service/method request ill-formed: unknown-method' on tcp://127.0.0.1:6001

Instead, this happened:

Error 'rpc: service/method request ill-formed: unknown-method; rpc: service/method request ill-formed: unknown-method' on tcp://127.0.0.1:6001

The version of RR used: 2.3.0 (stable)

Errortrace, Backtrace or Panictrace

*not required*

PHP code now located in spiral/goridge-php repository. So, current state in master branch can be a little bit cleared.

Yes, I know about #91. But this iteration must be made anyway, I think.

In production whenever the worker is being terminated by Roadrunner normally or by stopping the main process, I am getting an ErrorException with the following message:

unpack(): Type C: not enough input, need 1, have 0

on line: https://github.com/spiral/goridge/blob/c522eec9d8215c6059eeb4647d37003a2726e346/src/StreamRelay.php#L152

Goridge version: v2.4.4 Roadrunner version: v1.5.1

Since version 2.2.0 (after execution composer update) i'v got an error:

resource `in` must be readable in /app/vendor/spiral/goridge/php-src/StreamRelay.php:43

In my code, I create StreamRelay using the following code:

new \Spiral\Goridge\StreamRelay(\STDIN, \STDOUT);

And got an error, describet above. It happens because since version 2.2.0 this package uses next assert:

    /**
     * Checks if stream is readable.
     *
     * @param resource $stream
     *
     * @return bool
     */
    private function assertReadable($stream): bool
    {
        $meta = stream_get_meta_data($stream);
        return in_array($meta['mode'], ['r', 'r+', 'w+', 'a+', 'x+', 'c+'], true);
    }

Previos checking method was better: $this->assertMode($in, 'r')

But this method does not allows to use binary safe mode (b), which appended to the STDIN and STDOUT by default:

$ docker run --rm php:7.3.0-alpine php -r 'var_dump(stream_get_meta_data(\STDIN)["mode"]);'
string(2) "rb"

$ docker run --rm php:7.2.0-alpine php -r 'var_dump(stream_get_meta_data(\STDIN)["mode"]);'
string(2) "rb"

So, my applications cannot be started after update =(

I tried to add metrics into my application and hit into following error:

roadrunner_1  | WARN[0020] Error: Call to undefined function Spiral\Goridge\socket_create() in /www/vendor/spiral/goridge/php-src/SocketRelay.php:275 
roadrunner_1  | WARN[0020] Stack trace:                                 
roadrunner_1  | WARN[0020] #0 /www/vendor/spiral/goridge/php-src/SocketRelay.php(185): Spiral\Goridge\SocketRelay->createSocket() 
roadrunner_1  | WARN[0020] #1 /www/vendor/spiral/goridge/php-src/SocketRelay.php(88): Spiral\Goridge\SocketRelay->connect() 
roadrunner_1  | WARN[0020] #2 /www/vendor/spiral/goridge/php-src/RPC.php(47): Spiral\Goridge\SocketRelay->send('metrics.Add\x00\x00\x00\x00...', 20) 
roadrunner_1  | WARN[0020] #3 /www/vendor/spiral/roadrunner/src/Metrics.php(44): Spiral\Goridge\RPC->call('metrics.Add', Array) 
roadrunner_1  | WARN[0020] #4 /www/psr-worker.php(29): Spiral\RoadRunner\Metrics->add('app_metric_coun...', 1) 
roadrunner_1  | WARN[0020] #5 {main}                                    

RR version is 1.4.7. The reason is inexisting Sockets extension.

Suggestion: to require it in composer.json as "ext/sockets" OR to mention it in documentation and to throw exception if (!extension_loaded('sockets')) in createSocket

P.S. There are also some json_encode in Spiral\Goridge\RPC, so it's better to add ext/json to require too.

got a weird error for a service that was already running for a week: when looking at the code it can only be triggered if leftBytes is negative? is that possible?

data = make([]byte, 0, leftBytes)

panic: runtime error: makeslice: cap out of range
goroutine 89191655 [running]:
github.com/spiral/goridge.(*SocketRelay).Receive(0xc420142330, 0x0, 0x0, 0x0, 0x28, 0xc42047bda0, 0x0, 0x0)
        /Users/jayme/Documents/projects/go/src/github.com/spiral/goridge/socket.go:54 +0x20e
github.com/spiral/goridge.(*Codec).ReadRequestBody(0xc420346000, 0x0, 0x0, 0x0, 0x0)
        /Users/jayme/Documents/projects/go/src/github.com/spiral/goridge/codec.go:48 +0x48
net/rpc.(*Server).readRequest(0xc4201360a0, 0x93b520, 0xc420346000, 0x725fc0, 0x992af8, 0x93b520, 0xc420346000, 0x79a91f, 0x28, 0x0, ...)
        /usr/local/Cellar/go/1.9/libexec/src/net/rpc/server.go:547 +0xe1
net/rpc.(*Server).ServeCodec(0xc4201360a0, 0x93b520, 0xc420346000)
        /usr/local/Cellar/go/1.9/libexec/src/net/rpc/server.go:460 +0x77
net/rpc.ServeCodec(0x93b520, 0xc420346000)
        /usr/local/Cellar/go/1.9/libexec/src/net/rpc/server.go:669 +0x41
created by main.main