I have 18 local branches and 8 remote branches, every single one (except main) having been merged into main via a pull request.

When I run gh poi in the repo, all branches show in Not deleted branches and nothing is deleted.

It is a public organization repo for an organization including only me. I have confirmed all other gh commands and extensions work as designed.

Your Environment

• OS: macOS Monterey 12.3.1
• gh (Check with gh --version): 2.7.0
• gh-poi (For gh v2.6+ check with gh extension list): 0.4.0

Describe the bug

(synapse) [email protected]:~/dev/synapse$ gh poi
⠼ Fetching pull requests...panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
main.isFullyMerged({0x0, {0xc0000b631a, 0x7}, {0x62e8d0, 0x0, 0x0}, {0xc00021c480, 0x1, 0x1}, 0x0}, ...)
        /home/runner/work/gh-poi/gh-poi/poi.go:311 +0xe5
main.getDeleteStatus({0x0, {0xc0000b631a, 0x7}, {0x62e8d0, 0x0, 0x0}, {0xc00021c480, 0x1, 0x1}, 0x0}, ...)
        /home/runner/work/gh-poi/gh-poi/poi.go:295 +0x158
main.checkDeletion({0xc0000d5500, 0x53, 0xa}, {0xc000190030, 0x25})
        /home/runner/work/gh-poi/gh-poi/poi.go:275 +0x11e
main.GetBranches({0x547f10, 0x62e8d0}, 0x0)
        /home/runner/work/gh-poi/gh-poi/poi.go:120 +0x24d
main.runMain(0x0)
        /home/runner/work/gh-poi/gh-poi/main.go:42 +0x165
main.main()
        /home/runner/work/gh-poi/gh-poi/main.go:26 +0xbb

I'm not entirely sure how to fetch more information, please suggest me git commands to run to gain more info.

Your Environment

• OS: PopOS 21.10
• gh --version: gh version 2.4.0 (2021-12-21)

Before:

• The underlying cmd.Start() error was not reported in the wrapped error message
• The error from cmd.Wait() was swallowed
• The presence of stderr output was interpreted as command failure
• execabs package was used for security

Now:

• Start() + Wait() are replaced with cmd.Run()
• The Run() error is wrapped but not swallowed
• Process exit status is used as indicator of failure instead of the contents of stderr
• safeexec package is used to allow relative PATH entries

Describe the bug

Given a PR like this which is raised against the develop branch, from the develop branch of a fork, gh pr checkout 1781 creates the c-steindl/develop branch locally. Running gh poi after merging the PR does not delete this branch.

Your Environment

• OS: Linux Mint 20.3
• gh --version: gh version 2.5.1 (1980-01-01)

Describe the bug If the remotes looks like this: git remote -v

origin  [email protected]:seachicken/a.git (fetch)
origin  [email protected]:seachicken/a.git (push)
upstream        [email protected]:upstream/a.git (fetch)
upstream        [email protected]:upstream/a.git (push)

PRs in origin are not shown in the results of gh poi.

Your Environment

• OS: macOS Monterey
• gh --version: 2.5.0

Description When a PR branch is currently checked out, gh-poi will not delete the branch. A way to fix this would be to checkout the default branch and then delete the branch.

Additional context

hub-sync implemented this same functionality and the way I described above is how this tool dealt with the problem.

$ gh poi --dry-run
== DRY RUN ==
✕ Fetching pull requests...
failed to run external command: git, args: [status --short]
warning: could not open directory '_many_modules/': Permission denied

Where _many_modules is a directory I had removed permissions to, i.e. chmod a-rwx _many_modules

git status returns with exit code 0 in this case, but it does print that warning to stderr.

Your Environment

• OS: Ubuntu 21.10
• gh: 2.10.1
• gh-poi: v0.5.2

Description Bear with me, as this is half way between a bug report and a feature request. I am also willing to help 'fix' this, if given some pointers on where and how.

I like the extension, and would love to use it more, however... If you have used the strategy to handle multiple github accounts (a version of which is here), you potentially have a non-resolving domain in your remotes somewhere, along the lines of [email protected]:me/blah.git. The hack in the .ssh/config file turns this back into github.com, and everything is good as far as git goes (and the correct identity/ssh key gets used)

However, of course this doesn't work in gh-poi:

== DRY RUN ==
✕ Fetching pull requests...
failed to run external command: gh
error connecting to github.com-work
check your internet connection or https://githubstatus.com

I'm not entirely sure what I am suggesting here. Something along the lines of: If its an ssh type remote, then check ~/.ssh/config for a remapping?

I'm not entirely sure. I do know, however, that I am not the only person who uses this method, so thought I would open a conversation on it.

Additional context

None that I can think of.

Currently, GitHub has two types of URLs: one is SSH, another is HTTPS. The getHostname function seems not to support HTTPS URL; therefore, gh-poi panics due to no matches in case of using HTTPS URL.

⠋ Fetching pull requests... panic: runtime error: index out of range [1] with length 0

goroutine 1 [running]:
main.getHostname({0x1400017a000, 0x6f})
        /home/runner/work/gh-poi/gh-poi/poi.go:106 +0xc4
main.GetBranches({0x100dc2d18, 0x100ea22f0})
        /home/runner/work/gh-poi/gh-poi/poi.go:67 +0x5c
main.main()
        /home/runner/work/gh-poi/gh-poi/main.go:38 +0x278

This PR brings a new regex that matches also HTTPS. You can check it out on regex101.com.

• Previous implementation: https://regex101.com/r/7pJr9R/1
• This change: https://regex101.com/r/PmJR16/1

Does not run "gh poi" on Windows.

PS C:\Users\seito\git\GitHub\can> gh poi --dry-run
== DRY RUN ==
✕ Fetching pull requests...
/seachicken/can --json owner --json name --json parent --json defaultBranchRef]
parse "https://github.com\r/api/graphql": net/url: invalid control character in URL

"\r\n" was not being parsed, so it was fixed.

Fixes #40

The PR was excluded from the deletion target due to a change in the process of linking PRs and branches, which has been corrected. Related PR: https://github.com/seachicken/gh-poi/pull/24