Signed-off-by: Steven Borrelli [email protected]

Description of your changes

Fixes #10

I have:

• [x] Read and followed Crossplane's [contribution process].
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

• Created bucket with the following yaml and validated in Influxdb Azure console:

apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket-borrelli-issue-26
spec:
  forProvider:
    description: borrelli-test-issue-10
    orgID: <redacted>
    retentionRules:
    - everySeconds: 0
      type: expire
  providerConfigRef:
    name: default

• Deleted bucket and validated in the Influxdb Azure Console

• Created a bucket with a 1 hour retention and confirmed in InfluxDB azure console:

apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket-borrelli-issue-26
spec:
  forProvider:
    description: borrelli-test-issue-26
    orgID: <redacted>
    retentionRules:
    - everySeconds: 3600
      type: expire
  providerConfigRef:
    name: default

• Changed retentionRules to everySeconds to 0 and confirmed in the InfluxDB Azure Console.
• Deleted Bucket and confirmed deletion. Reviewed Controller logs for any Panic.

Signed-off-by: Alper Rifat Ulucinar [email protected]

Description of your changes

Fixes #7 It looks like we have an issue while detecting/handling not-found errors for buckets. This PR fixes the issue in a minimalist manner.

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested with the following example manifest with a trial InfluxDB Cloud 2 account. Also tested the fix with an InfluxDB organization.

apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket2-alper
spec:
  forProvider:
    description: test-description
    orgID: 4133ee0939674b36
    retentionRules:
    - everySeconds: 3600
      type: expire
  providerConfigRef:
    name: default

❯ k get bucket
NAME                    READY   SYNCED   EXTERNAL-NAME           AGE
example-bucket2-alper   True    True     example-bucket2-alper   43m

Description of your changes

Because the provider does not publish Helm chart and this blocks the whole publishing.

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Will be tested by Github CI.

Description of your changes

Adds the first resource to this provider, Organization.

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually with example YAMLs.

Usual ritual.

One thing I need to do some extra work is whether it should be provider-influxdb-cloud or just provider-influxdb because it seems like InfluxDB Cloud provides the same API as OSS. For example, you can create organizations in both but cloud requires a new sign-up whereas you can just call the API and there is only a single Go client targeting both.

What happened?

I created a bucket by applying the following manifest:

apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket2
spec:
  forProvider:
    description: example-bucket2
    orgID: SOME_ORG_ID
    retentionRules:
    - everySeconds: 0
      type: expire
  providerConfigRef:
    name: default

The bucket got created and was visible on the InfluxDB Cloud 2.0 UI.

Although the resource never got to the state Ready: True. See below:

$ kubectl get buckets.influxdb.crossplane.io                
NAME              READY   SYNCED   EXTERNAL-NAME     AGE
example-bucket2           True     example-bucket2   5m15s

Then I tried to delete with:

$ kubectl delete buckets.influxdb.crossplane.io example-bucket2
bucket.influxdb.crossplane.io "example-bucket2" deleted

Then the crossplane-provider-influxdb pod got into CrashLoopBackOff

NAME                                                              READY   STATUS             RESTARTS   AGE
pod/crossplane-78bf69f4cc-f2zmz                                   1/1     Running            0          27h
pod/crossplane-provider-azure-ddc1abaec4d0-665f9bb6c8-mplm8       1/1     Running            1          27h
pod/crossplane-provider-influxdb-ba2ab2715129-8567c78666-pz57p    0/1     CrashLoopBackOff   50         3h59m
pod/crossplane-provider-jet-azure-de7fdc8d3f04-84d4874476-dstzb   1/1     Running            0          27h
pod/crossplane-provider-sql-f6f5be714a28-545b559dcb-m8kw4         1/1     Running            0          27h
pod/crossplane-provider-tf-azure-529a2cefbfc7-5ffdf4f86b-8pdcl    1/1     Running            0          27h
pod/crossplane-rbac-manager-86996b55b4-dn57k                      1/1     Running            1          27h
pod/upbound-bootstrapper-65cbb55d7c-f8z54                         1/1     Running            0          27h
pod/xgql-9bbf5d9d7-4f75j                                          1/1     Running            0          27h

The following log output was seen on the pod mentioned above:

I0112 14:01:23.925955       1 request.go:668] Waited for 1.011662735s due to client-side throttling, not priority and fairness, request: GET:https://192.168.0.1:443/apis/postgresql.azure.tf.crossplane.io/v1alpha1?timeout=32s
panic: runtime error: index out of range [0] with length 0

goroutine 444 [running]:
github.com/crossplane-contrib/provider-influxdb/internal/controller/bucket.LateInitialize(0xc0001b2140, 0xc0000101e0, 0x1)
        /home/runner/work/provider-influxdb/provider-influxdb/internal/controller/bucket/conversions.go:129 +0x35f
github.com/crossplane-contrib/provider-influxdb/internal/controller/bucket.(*external).Observe(0xc0008440b0, 0x1c4cdc0, 0xc000319920, 0x1c6f690, 0xc0001b2000, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/runner/work/provider-influxdb/provider-influxdb/internal/controller/bucket/controller.go:98 +0x476
github.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile(0xc0006c44d0, 0x1c4cdf8, 0xc00092e360, 0x0, 0x0, 0xc0009826e0, 0xf, 0xc00092e300, 0x0, 0x0, ...)
        /home/runner/work/provider-influxdb/provider-influxdb/vendor/github.com/crossplane/crossplane-runtime/pkg/reconciler/managed/reconciler.go:679 +0x22ab
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0003234a0, 0x1c4cd50, 0xc000429540, 0x1879340, 0xc00091b340)
        /home/runner/work/provider-influxdb/provider-influxdb/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:298 +0x30d
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0003234a0, 0x1c4cd50, 0xc000429540, 0x663a226465636100)
        /home/runner/work/provider-influxdb/provider-influxdb/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:253 +0x205
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2(0xc0003b2010, 0xc0003234a0, 0x1c4cd50, 0xc000429540)
        /home/runner/work/provider-influxdb/provider-influxdb/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:214 +0x6b
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2
        /home/runner/work/provider-influxdb/provider-influxdb/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:210 +0x425

How can we reproduce it?

The steps are described in the what happened? section.

What environment did it happen in?

Crossplane version: upbound/crossplane:v1.5.1-up.1 Provider InfluxDB Cloud version: v0.1.1 Azure AKS Kubernetes 1.20.13

What happened?

I'm trying to create the following Bucket (external resource)

apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket2
spec:
  forProvider:
    description: test-description
    orgID: *******4e54da6
    retentionRules:
    - everySeconds: 0
      type: expire
  providerConfigRef:
    name: default

The bucket doesn't get created.

$ > kubectl describe Bucket example-bucket


Name:         example-bucket2
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: example-bucket2
API Version:  influxdb.crossplane.io/v1alpha1
Kind:         Bucket
Metadata:
  Creation Timestamp:  2022-01-06T18:50:00Z
  Generation:          1
  Managed Fields:
    API Version:  influxdb.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:deletionPolicy:
        f:forProvider:
          .:
          f:description:
          f:orgID:
          f:retentionRules:
        f:providerConfigRef:
          .:
          f:name:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2022-01-06T18:50:00Z
    API Version:  influxdb.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          f:crossplane.io/external-name:
      f:status:
        .:
        f:atProvider:
          .:
          f:links:
        f:conditions:
    Manager:         crossplane-influxdb-provider
    Operation:       Update
    Time:            2022-01-06T18:50:01Z
  Resource Version:  328220
  UID:               9d4acba6-e5fc-46ee-9d10-44423123123
Spec:
  Deletion Policy:  Delete
  For Provider:
    Description:  test-description
    Org ID:       YOUR_ORG_ID****
    Retention Rules:
      Every Seconds:  0
      Type:           expire
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
    Links:
  Conditions:
    Last Transition Time:  2022-01-06T18:50:01Z
    Message:               observe failed: cannot find bucket: not found: bucket "example-bucket2" not found
    Reason:                ReconcileError
    Status:                False
    Type:                  Synced
Events:
  Type     Reason                         Age              From                                   Message
  ----     ------                         ----             ----                                   -------
  Warning  CannotObserveExternalResource  4s (x4 over 5s)  managed/bucket.influxdb.crossplane.io  cannot find bucket: not found: bucket "example-bucket2" not found

How can we reproduce it?

• AKS cluster Kubernetes v1.20.13.
• Using a InfluxDB Cloud 2.0 account, Azure:

Install the provider:

kubectl crossplane install provider crossplane/provider-influxdb:v0.1.0

Apply the following:

---
apiVersion: v1
kind: Secret
metadata:
  namespace: crossplane-system
  name: influxdb-token
type: Opaque
stringData:
  authToken: YOUR_INFLUXDBCLOUD_TOKEN_ID==
---
apiVersion: influxdb.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: default
spec:
  endpoint: https://eastus-1.azure.cloud2.influxdata.com
  credentials:
    source: Secret
    secretRef:
      namespace: crossplane-system
      name: influxdb-token
      key: authToken
---
apiVersion: influxdb.crossplane.io/v1alpha1
kind: Bucket
metadata:
  name: example-bucket2
spec:
  forProvider:
    description: test-description
    orgID: YOUR_TEST_ORG
    retentionRules:
    - everySeconds: 0
      type: expire
  providerConfigRef:
    name: default

What environment did it happen in?

Crossplane version: upbound/crossplane:v1.5.1-up.1

Provider InfluxDB Cloud version: v0.1.0

Azure AKS

Kubernetes 1.20.13

Description of your changes

Looks like I forgot to remove that.

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually

Description of your changes

Add DatabaseRetentionPolicyMapping resource. Depends on https://github.com/crossplane-contrib/provider-influxdb/pull/3 only the last two commits are relevant.

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually with the given example.

Description of your changes

Adds Bucket CRD.

Fixes #

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually with example.