As proposed in PR #5, here is the integration test suite performed with an sqlite in-memory database.

It is composed of 2 files:

• sqlite_pod_test.go: tests performed on plain-old-data fields only
• sqlite_ptr_test.go: tests performed on a structure with a pointer field. Both cases are tested in each test function (nil and non-nil pointer)

The sqlite3 driver is provided by github.com/mattn/go-sqlite3 package

I'm proposing a new feature for Structable, the handling of pointer fields.

The main advantage to have this feature implemented in Structable is that pointer fields play well when you want to hide (or not include) some fields of a structure, before marshall it into JSON, or more generally to let a structure have different representations, depending on wether some pointer fields are nil.

Let's take this struct as an example:

type User struct {
    Id       int     `stbl:"id,PRIMARY_KEY" json:"id"`
    Name     string  `stbl:"name"           json:"name"`
    Email    string  `stbl:"email"          json:"email"`
    Password *string `stbl:"email"          json:"password,omitempty"`
}

This hypothetical User struct can be used as-is for both database mapping (through Structable) and Json marshalling. Json omitempty requires the field to be a pointer, it is an easy way to represent the absence of a field. We can now have different representations of an User, one with the password being included and another with the password hidden. Some other use cases exist. Some basic tests for pointer fields have been added to the existing test suite, they and included in this PR.

PS: I wrote a test suite, using an in-memory sqlite database backend, that could be considered as integration tests, however I didn't include it so as to keep focused the field of this PR focused on the feature. If you are interested I can push it here or in another PR.

Do you think hooks fit in structable's design? For example, I have a struct

type Object struct {
    Id int `stbl:"id, PRIMARY_KEY, AUTO_INCREMENT"`
    PropsJSON string `stbl:"props_json"`
    CreatedAt time.Time `stbl:"create_at"`
    UpdatedAt time.Time `stbl:"updated_at"`

    Props map[string]string
}

I want CreateAt and UpdatedAt updated and PropsJSON <=> Props get transformed automatically. My first thought is that if structable supports Hooks I can write following methods:

// called before Insert
func (this *Object) BeforeInsert() {
    this.CreatedAt = time.Now()
}

// called before Update
func (this *Object) BeforeUpdate() {
    this.UpdatedAt = time.Now()
}

// called before Insert and Update
func (this *Object) BeforeSave() {
    _, this.ProsJSON = json.Marshal(&this.Props)
}

// called after Load
func (this *Object) AfterLoad() {
    json.Unmarshal([]byte(this.PropsJSON), &this.Props)
}

Do you think this is a good idea?

Thanks!

It seems that ListWhere() is unable to convert a []Recorder back to its real type and returns an empty base object. Further investigation showed that there is a contradiction within the function on how to handle keys.

The below snippet shows that the includeKeys parameter of Column() is false hence columns that are marked as keys will be omitted from the returned list.

https://github.com/Masterminds/structable/blob/a1a302ef78ec3d85606dcf104a9a168542004036/structable.go#L309

However, later the withKeys parameter of FieldReferences() is true hence fields marked as keys will be included in the returned list.

https://github.com/Masterminds/structable/blob/a1a302ef78ec3d85606dcf104a9a168542004036/structable.go#L340

This will currently result in a mismatch between the number of columns and throw an ERROR: sql: expected 19 destination arguments in Scan, not 20 message. Unfortunately, errors returned by rows.Scan(dest...) are ignored hence the function will silently fail and return an empty base object.

Is there a listing of type support for this library? I am currently using a struct like this, and was wondering if structable would automatically transform the *timestamp.Timestamp into a postgresql DATE type.

type PgData struct {
	TenantID  string 
	AssetID   string 
	JobID     string 
	FormatID  string
	Status    status
	StartTime *timestamp.Timestamp
	EndTime   *timestamp.Timestamp
}