Hello.

IDs where nil and my script worked fine. Now the ids are required. Why? My script is getting game realeases between two dates where ids are not existing. Is there other way i could achieve that after update.

Updated Game Category enums to support the values:

• mod, 5
• episode, 6
• season, 7

IGDB documentation: https://api-docs.igdb.com/#game-enums

I regenerated the go generate files via stringer and looks like more recent versions output an additional func than originally.

There may be an additional required header to be sent in each request for pro and enterprise tier users. If this is the case, the auth token must be supported in the NewClient function or another function entirely.

SetLimit and SetOffset returns error if number higher than 5000 is provided.

There is no limit for offset for IGDB v4 API.

Limit also changed to 500 (not 5000 as in the code).

According to: https://api-docs.igdb.com/#pagination

When attempting to assert that the errors.Cause(err) of a returned error from a service is Temporary for the new ratelimiting requirements:

type temporary interface {
        Temporary() bool
}

func IsTemporary(err error) bool {
        te, ok := errors.Cause(err).(temporary)
        fmt.Printf("IS TEMPORARY %#v %t\n", errors.Cause(err), ok)
        return ok && te.Temporary()
}

This prints:

IS TEMPORARY igdb.ServerError{Status:429, Msg:"too many requests", Temp:true} false

errors.Cause() returns a plain igdb.ServerError, not *igdb.ServerError, and a plain igdb.ServerError does not implement temporary. Only *igdb.ServerError has the required Temporary method: https://github.com/Henry-Sarabia/igdb/blob/dcac61d5a6ea36eb1265af5e5f0cfdf479adf14f/error.go#L72

Is there any reason we can't define this method on igdb.ServerError as that will cover both plain struct and pointer?

https://api-docs.igdb.com/#upgrading-to-v4-from-v3

Updating Authentication

• Changed from user-key to client-id
• Added AppAccessToken as required param
• Added x-user-agent as a way of identifying client code that may need updates.

Methods

• Changed from GET to POST

Endpoints

| Endpoint | Change | |-------------------|-----------| |achievement_icons |Removed | |achievements |Removed | |feed_follows |Removed | |feeds |Removed | |follows |Removed | |list_entries |Removed | |lists |Removed | |page_backgrounds |Removed | |page_logos |Removed | |page_websites |Removed | |pages |Removed | |product_families |Renamed to platform_families | |pulse_images |Removed | |pulse_groups |Removed | |pulse_sources |Removed | |pulse_urls |Removed | |pulses |Removed | |rates |Removed | |review_videos |Removed | |reviews |Removed | |status |Removed | |time_to_beats |Removed | |titles |Removed |

Changed Fields

|Object |Endpoint |Field |Change| |-----------|-----------|---------------|------| |Game |games |popularity |Removed| |Game |games |pulse_count |Removed| |Game |games |time_to_beat |Removed| |Platform |platforms |product_family |Renamed to platform_family| |Search |search |popularity |Removed|

The IGDB API now supports field expansion. Field expansion allows a user to denote subfields to retrieve in addition to the regular fields of a request. Because Go is a statically typed language, when additional subfields are sent back in the JSON object, the object will no longer match the defined struct and the JSON decoder will return an error.

Here are three options for dealing with this problem.

1. Ignore the issue and simply let the package return a JSON decoder error when expansion is used.
2. Take a half-measure and fail early. Document the lack of expansion support and check for any expanded fields before sending the request. If an expanded field is found, return an error explaining the lack of expansion support.
3. Take a half-measure and return an untyped object. Add an extra function for each endpoint that allows expansion but will return an untyped map of the JSON object instead of a proper populated Go struct type.

IGDB has a set of private endpoints meant for pro tier users. Three of these endpoints are listed under the regular list of endpoints so they are already implemented, but there still remains a dozen unimplemented endpoints.

Test coverage has dropped to 92% after the most recent pull request. It would be prudent to reevaluate the current suite of tests to raise the overall test coverage.

Wanted to start playing around with the IGDB API, but it turns out that new API keys are only valid for this new API v3 endpoint.

I'm not sure if more changes are probably in order for v3 compatibility: https://api-docs.igdb.com/#migration-to-v3

Hey! I'm new to using this project and looks like it will be perfect if I can get it running.

When getting the project from github (and when trying to build my own project) I'm getting the following error:

../../../../../github.com/Henry-Sarabia/igdb/testing.go:44: ts.Client undefined (type *httptest.Server has no field or method Client)

I pulled the latest about an hour ago.

Thanks!

There might be an issue filtering by non-id fields for GameVideos.Index().

Querying the IGDB API https://api.igdb.com/v4/game_videos directly with the following body yields a single item.

Body:

fields name,video_id;
where id = 48965;
limit 500;
offset 0;

Response:

[
    {
        "id": 48965,
        "name": "Announcement Trailer",
        "video_id": "61-OMrOxyso"
    }
]

Querying by name instead of id yields a response with multiple items:

Body:

fields name,video_id;
where name = ("Announcement Trailer");
limit 500;
offset 0;

When using this library, filtering by ID works but not by Name. Works:

options := igdb.ComposeOptions(
		igdb.SetLimit(500),
		igdb.SetOffset(0),
		igdb.SetFields("name, video_id"),
		igdb.SetFilter("id", igdb.OpContainsAtLeast, "48965"),
	)

videos, err := IGDB.GameVideos.Index(options)

Doesn't Work:

options := igdb.ComposeOptions(
		igdb.SetLimit(limit),
		igdb.SetOffset(offset),
		igdb.SetFields("name, video_id"),
		igdb.SetFilter("name", igdb.OpContainsAtLeast, "Announcement Trailer"),
	)

videos, err := IGDB.GameVideos.Index(options)

We get the following error with the above request: Error: cannot get index of GameVideos: cannot make POST request: igdb server error: status: 400 message: bad request: check query parameters

Any thoughts on how we can fix this?

Thanks!

Hello,

website.go has the following struct:

type Website struct {
	ID       int             `json:"id"`
	Category WebsiteCategory `json:"category"`
	Trusted  bool            `json:"trusted"`
	URL      string          `json:"url"`
}

Game is also available via the API, but not exposed in this struct. See https://api-docs.igdb.com/#website

Can we add it? Should look like:

type Website struct {
	ID       int             `json:"id"`
	Category WebsiteCategory `json:"category"`
        Game     int             `json:"game"`
	Trusted  bool            `json:"trusted"`
	URL      string          `json:"url"`
}

Let me know if you want me to open a PR with this change. Thanks!