This provider is intended to be used with Router OS 7 and above. It makes use of the REST API introduced with Router OS v7.
Please refer to the documentation
See changelog.md
Describe the bug I setup a RouterOS with two addresses (*1 and *2, using 10.0.9.1/24 and 192.168.88.1/24), the REST api also returns the correct values.
Using the terraform provider, the list contains the same address twice and is missing the first one. When I create a third address, the array contains three times the last one.
This is also reproducable for the interfaces and routes datasource.
ip_addresses = {
"addresses" = tolist([
{
"actual_interface" = "ether1"
"address" = "192.168.88.1/24"
"disabled" = true
"dynamic" = false
"id" = "*2"
"interface" = "ether1"
"invalid" = false
"network" = "192.168.88.0"
},
{
"actual_interface" = "ether1"
"address" = "192.168.88.1/24"
"disabled" = true
"dynamic" = false
"id" = "*2"
"interface" = "ether1"
"invalid" = false
"network" = "192.168.88.0"
},
])
"id" = "terraform-20220120102446891700000001"
}
To Reproduce Setup multiple routes, addresses or interfaces and query those.
Minimal terraform example:
provider "routeros" {
hosturl = "https://10.0.9.150"
username = "admin"
password = ""
insecure = true
}
data "routeros_interfaces" "interfaces" {}
data "routeros_ip_routes" "routes" {}
data "routeros_ip_addresses" "addresses" {}
output "interfaces" {
value = data.routeros_interfaces.interfaces
}
output "ip_addresses" {
value = data.routeros_ip_addresses.addresses
}
output "routes" {
value = data.routeros_ip_routes.routes
}
Expected behavior Array with the correct entries.
bugGitHub actions should be added to the repository to:
Describe the bug
There is a call to fmt.Println for the HTTP request after the HTTP Basic Auth credentials are set, resulting in the base64 encoded credentials being written to stdout. The base64 string can easily be decoded to retrieve the original credentials. This is a significant security issue as it is very common for the output from stdout and stderr to be logged and the logs to be shipped to logging services where the logs are visible to many users.
https://github.com/GNewbury1/terraform-provider-routeros/blob/0cab8e158a493160863e5d471fea65d35507445f/client/client.go#L55-L59
To Reproduce https://go.dev/play/p/0_Tn0cCp7lM
Expected behavior Provider does not write credentials to stdout.
Additional context
This issue may also exist elsewhere in the code, I haven't looked. You should remove all debug fmt.Print commands from the provider.
This seemed to work well during minimal testing, it could use a thorough review though.
I also couldn't get the doc generation to work, so you may need to add those.
Fixed an issue where when reading routeros_interface_bridge, the Arp field was treated as a bool where it should be a string
Full Changelog: https://github.com/GNewbury1/terraform-provider-routeros/commits/v0.2.0
Source code(tar.gz)Full Changelog: https://github.com/GNewbury1/terraform-provider-routeros/compare/v0.1.0...v0.1.1
Source code(tar.gz)Initial provider release
Full Changelog: https://github.com/GNewbury1/terraform-provider-routeros/commits/v0.1.0
Source code(tar.gz)terraform-provider-awsutils Terraform provider for performing various tasks that cannot be performed with the official AWS Terraform Provider from Has
Terraform Provider for Azure (Resource Manager) Version 2.x of the AzureRM Provider requires Terraform 0.12.x and later, but 1.0 is recommended. Terra
Terraform Provider Scaffolding (Terraform Plugin SDK) This template repository i
Terraform Provider for Buddy Documentation Requirements Terraform >= 1.0.11 Go >
Vercel Terraform Provider Website: https://www.terraform.io Documentation: https
Age Terraform Provider This provider lets you generate an Age key pair. Using th
Terraform Operator The Terraform Operator provides support to run Terraform modu
Terraform-In-Terraform Provider This provider allows running Terraform in Terraform. This might seem insane but there are some edge cases where it com
Terraform Bash Provider This is a Terraform utility provider which aims to robustly generate Bash scripts which refer to data that originated in Terra
Terraform Provider Scaffolding (Terraform Plugin Framework) This template repository is built on the Terraform Plugin Framework. The template reposito
Terraform Provider Scaffolding (Terraform Plugin SDK) This template repository is built on the Terraform Plugin SDK. The template repository built on
Terraform Provider OpenAPI This terraform provider aims to minimise as much as possible the efforts needed from service providers to create and mainta
Terraform Provider HashiCups Run the following command to build the provider go
terraform-grafana-dashboard terraform-grafana-dashboard for project Requirements
(work in progress) TOSCA for Terraform Enable TOSCA for Terraform using Puccini.
terraform-ncloud-docs Overview This docs help to use terraform creation server C
Terraform House Manage your own terraform workflow using go language, with the b
LTF Status: alpha LTF is a minimal, transparent Terraform wrapper. It makes Terraform projects easier to work with. In standard Terraform projects, th
TERRAFORM CONTROLLER Terraform Controller manages the life cycles of a terraform resource, allowing developers to self-serve dependencies in a control
19 Jun 24, 2022
0 Oct 16, 2021
0 Dec 31, 2021
1 Jan 5, 2022
54 Jun 25, 2022
0 Feb 15, 2022
37 Jun 6, 2022
36 Jun 16, 2022
32 Jun 23, 2022
38 Jun 27, 2022
0 Feb 8, 2022
207 Jun 26, 2022
1 Jan 10, 2022
1 May 2, 2022
3 Mar 30, 2022
1 Mar 4, 2022
0 Feb 17, 2022
7 May 19, 2022
40 Jun 27, 2022